feat: replace GCS TestPermissions health check with probe object round-trip#4683
Open
antonio-altr wants to merge 2 commits into
Open
feat: replace GCS TestPermissions health check with probe object round-trip#4683antonio-altr wants to merge 2 commits into
antonio-altr wants to merge 2 commits into
Conversation
antonio-altr
force-pushed
the
feat/replace-gcs-testpermissions
branch
2 times, most recently
from
4a76db2 to
f784fe3
Compare
…vice.GetByHash context.Canceled is expected when the ReaderTimeoutWrapper or RedundantStorageService returns early because a faster inner service already succeeded. Logging it at ERROR level is misleading — the overall call succeeded.
antonio-altr
force-pushed
the
feat/replace-gcs-testpermissions
branch
from
f784fe3 to
e7e0331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GCS
HealthCheckusesbucket.IAM().TestPermissions()to verify that the daserver service account has the required storage permissions. However, GCP's testIamPermissions API has a documented limitation: it does not evaluate conditional IAM bindings. When permissions are granted via a condition (e.g.resource.name.startsWith("projects/_/buckets/my-bucket/objects/my-prefix/")), the API always returns an empty list — even if the service account can actually read and write to the bucket.Fix
Replace the
TestPermissionscall with an actual write/read/delete round-trip on a small probe object at<objectPrefix>.health-check-probe. This exercises the real permissions path and works correctly for both unconditional and conditional IAM bindings.Notes
sortandgo-cmpimports are removed as they are no longer used